[webkit-reviews] review denied: [Bug 63359] convert editing/deleting/5156801-2.html to dumpAsText and rename : [Attachment 98557] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 63359: convert editing/deleting/5156801-2.html to dumpAsText and rename
https://bugs.webkit.org/show_bug.cgi?id=63359

Attachment 98557: Patch
https://bugs.webkit.org/attachment.cgi?id=98557&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98557&action=review

> LayoutTests/editing/deleting/delete-node-after-DOMNodeRemoved-2.html:2
> +<p>This tests for a crash when deleting the contents of a table cell. You
should just see 'Cached' below.</p>

Please add rdar id.

> LayoutTests/editing/deleting/delete-node-after-DOMNodeRemoved-2.html:16
> +s = window.getSelection();
> +table = document.getElementById("table");
> +s.setPosition(table, table.childNodes.length);
> +s.modify("move", "backward", "character");
> +document.execCommand("Delete");
> +document.execCommand("Delete");
> +document.execCommand("Delete");
> +document.execCommand("Delete");
> +document.execCommand("Delete");
> +document.execCommand("Delete");
> +document.execCommand("Delete");

What is this test to do with DOMNodeRemoved?  That's a DOM level 3 event.  I
don't see an event listener attached in this test case.  r- due to this.