[webkit-reviews] review denied: [Bug 57784] [Qt][WK2] Qt port needs load-from-history implementation : [Attachment 98347] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Jamie Cooley
<james.cooley at nokia.com>'s request for review:
Bug 57784: [Qt][WK2] Qt port needs load-from-history implementation
https://bugs.webkit.org/show_bug.cgi?id=57784

Attachment 98347: Patch
https://bugs.webkit.org/attachment.cgi?id=98347&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98347&action=review

Looks mostly great, just some minor itches:

> Source/WebKit2/ChangeLog:8
> +	   Created "random access" ForwardBackHistory public API method,

Typo, BackForwardHistory.

> Source/WebKit2/ChangeLog:17
> +	   Updated createHistroy method and QWKHistoryPrivate constructor to
take a pointer

Typo, createHistory.

> Source/WebKit2/ChangeLog:18
> +	   to the owning QWKPage in addtion to the WebBackForwardList. This
will be saved so that the

Typo, addition.

> Source/WebKit2/UIProcess/API/qt/qwkhistory.h:51
> +    WKBackForwardListItemRef itemRef() const;

We shouldn't use WK2 types in our APIs, QWKHistory and QWKHistoryItem should be
friends and grab at each others private members directly instead.