[webkit-reviews] review granted: [Bug 63194] TestFailures page should show closed bugs, too : [Attachment 98353] Show closed bugs on the TestFailures page in addition to open ones

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 63194: TestFailures page should show closed bugs, too
https://bugs.webkit.org/show_bug.cgi?id=63194

Attachment 98353: Show closed bugs on the TestFailures page in addition to open
ones
https://bugs.webkit.org/attachment.cgi?id=98353&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98353&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewCo
ntroller.js:238
> +	       list.appendChildren(openBugs.map(bugToListItem));

What if all the bugs found are closed?	Shouldn't you check if openBugs.length
here, or is that checked above?

    if (openBugs.length)
	list.appendChildren(openBugs.map(bugToListItem));