[webkit-reviews] review granted: [Bug 20797] add Settings entries for per-script/lang generic family : [Attachment 98269] patch updated per ap's comments

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jungshik Shin
<jshin at chromium.org>'s request for review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 98269: patch updated per ap's comments
https://bugs.webkit.org/attachment.cgi?id=98269&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98269&action=review

> Source/JavaScriptCore/GNUmakefile.list.am:633
> +	Source/JavaScriptCore/wtf/unicode/ScriptcodesFromICU.h \

This still has the typo.

> Source/JavaScriptCore/wtf/unicode/Unicode.h:31
> +#include <unicode/uscript.h>

This should be in UnicodeIcu.h, similar to others.