[webkit-reviews] review granted: [Bug 63155] Add NSError wrapper functions in ResourceError when USE(CFNETWORK) is enabled : [Attachment 98239] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 22 17:30:19 PDT 2011
Darin Adler <darin at apple.com> has granted Pratik Solanki <psolanki at apple.com>'s
request for review:
Bug 63155: Add NSError wrapper functions in ResourceError when USE(CFNETWORK)
is enabled
https://bugs.webkit.org/show_bug.cgi?id=63155
Attachment 98239: Patch
https://bugs.webkit.org/attachment.cgi?id=98239&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98239&action=review
> Source/WebCore/platform/network/mac/ResourceErrorMac.mm:58
> + RetainPtr<NSDictionary> userInfo(AdoptCF, (NSDictionary *)
CFErrorCopyUserInfo(error));
> + m_platformNSError.adoptNS([[NSError alloc]
initWithDomain:(NSString*)CFErrorGetDomain(error) code:CFErrorGetCode(error)
userInfo:userInfo.get()]);
Different formatting of the typecasts on two successive lines.
More information about the webkit-reviews
mailing list