[webkit-reviews] review requested: [Bug 62459] Local files cannot load icons. : [Attachment 98076] Modified constraint to what has been suggested, moved it to IconDatabase class, and added that check to IconController

[bugzilla-daemon at webkit.org]

Rafael Brandao <rafael.lobo at openbossa.org> has asked  for review:
Bug 62459: Local files cannot load icons.
https://bugs.webkit.org/show_bug.cgi?id=62459

Attachment 98076: Modified constraint to what has been suggested, moved it to
IconDatabase class, and added that check to IconController
https://bugs.webkit.org/attachment.cgi?id=98076&action=review

------- Additional Comments from Rafael Brandao <rafael.lobo at openbossa.org>
I've moved it to IconDatabase class because it is mainly used there, so the
code wouldn't need to change. This move make it visible for IconController, so
I added the pageCanHaveIcon there, and in case it can't, I just don't download
any resource. With this change, if we ever change the constraint again and make
local files to not have their favicons, this new layout test won't get the
resource callback, thus failing.

I'm looking forward for feedback on this. Thanks!