[webkit-reviews] review granted: [Bug 58497] Implement drawingBufferWidth/drawingBufferHeight in WebGL : [Attachment 98072] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 58497: Implement drawingBufferWidth/drawingBufferHeight in WebGL
https://bugs.webkit.org/show_bug.cgi?id=58497

Attachment 98072: Patch
https://bugs.webkit.org/attachment.cgi?id=98072&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98072&action=review

Looks good overall. One comment, and please make sure any relevant tests are
synchronized with the WebGL conformance suite.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:608
> +    if (width > maxWidth)
> +	   width = maxWidth;
> +    if (width <= 0)
> +	   width = 1;

How about a "clamp" helper function? (Too bad the STL doesn't contain one...)