[webkit-reviews] review granted: [Bug 63069] Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend. : [Attachment 97997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 10:32:27 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 63069: Web Inspector: Move logic for deciding whether resource content
should be base64 encoded on backend.
https://bugs.webkit.org/show_bug.cgi?id=63069

Attachment 97997: Patch
https://bugs.webkit.org/attachment.cgi?id=97997&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97997&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:493
> +		   if (cachedResourceContent(cachedResource, &content,
&base64Encoded) && !base64Encoded) {

Replace condition with ASSERT.


More information about the webkit-reviews mailing list