[webkit-reviews] review granted: [Bug 60303] animation-timing-function property with a list uses first item for all animations : [Attachment 98005] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Young Han Lee
<joybro at company100.net>'s request for review:
Bug 60303: animation-timing-function property with a list uses first item for
all animations
https://bugs.webkit.org/show_bug.cgi?id=60303

Attachment 98005: Patch
https://bugs.webkit.org/attachment.cgi?id=98005&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98005&action=review

> LayoutTests/animations/multiple-animations-on-an-element.html:35
> +	   runAnimationTest(expectedValues, null, null, true);

Why does this have to disable the pause API?

> Source/WebCore/page/animation/KeyframeAnimation.cpp:153
> +    const Animation* matchedAnimation =
getAnimationFromStyleByName(fromStyle, name());
> +    if (matchedAnimation)

We usually write this:
if (const Animation* matchedAnimation = getAnimationFrom...)
    ...