[webkit-reviews] review denied: [Bug 62807] SVGAnimation should use direct unit animation for SVGAngle : [Attachment 97492] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 62807: SVGAnimation should use direct unit animation for SVGAngle
https://bugs.webkit.org/show_bug.cgi?id=62807

Attachment 97492: Patch
https://bugs.webkit.org/attachment.cgi?id=97492&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97492&action=review

Looks good in general, the description needs to be fixed though and I posted a
question.

> Source/WebCore/svg/SVGAnimateElement.cpp:555
> +	   || m_animatedAttributeType == AnimatedLength)

Could be on one line.

> LayoutTests/svg/animations/script-tests/svgangle-animation-deg-to-grad.js:1
> +description("Test SVGLength animation from px to cm.");

Please fix all descriptions.

> LayoutTests/svg/animations/script-tests/svgangle-animation-rad-to-grad.js:22
> +marker.appendChild(polyline);

Is it possible to put the above setup work into the html? Would make the js
files smaller.