[webkit-reviews] review granted: [Bug 62820] Introduced SlotVisitor into the project : [Attachment 97498] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 16 14:29:46 PDT 2011


Oliver Hunt <oliver at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 62820: Introduced SlotVisitor into the project
https://bugs.webkit.org/show_bug.cgi?id=62820

Attachment 97498: Patch
https://bugs.webkit.org/attachment.cgi?id=97498&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97498&action=review

r=me if you fix the style problem

>> Source/WebCore/dom/NodeFilterCondition.h:32
>> -	class MarkStack;
>> -	typedef MarkStack SlotVisitor;
>> +	class SlotVisitor;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

Fixerate this.


More information about the webkit-reviews mailing list