[webkit-reviews] review denied: [Bug 62637] [Qt] [WK2] Qt WebKit2 needs undo/redo support : [Attachment 97449] fix patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 16 10:14:16 PDT 2011
Sam Weinig <sam at webkit.org> has denied Chang Shu <cshu at webkit.org>'s request
for review:
Bug 62637: [Qt] [WK2] Qt WebKit2 needs undo/redo support
https://bugs.webkit.org/show_bug.cgi?id=62637
Attachment 97449: fix patch 4
https://bugs.webkit.org/attachment.cgi?id=97449&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97449&action=review
> Source/WebKit2/UIProcess/qt/WebUndoCommandQt.h:36
> + WebUndoCommandQt(WTF::PassRefPtr<WebKit::WebEditCommandProxy>,
QUndoCommand* parent = 0);
WTF:: not needed here.
> Source/WebKit2/UIProcess/qt/WebUndoCommandQt.h:38
> + WebUndoCommandQt(WTF::PassRefPtr<WebKit::WebEditCommandProxy>);
WTF:: not needed here.
> Source/WebKit2/UIProcess/qt/WebUndoCommandQt.h:45
> + bool inUndoRedo() const { return m_inUndoRedo; };
Missing newline after this function.
> Source/WebKit2/UIProcess/qt/WebUndoCommandQt.h:47
> + WTF::RefPtr<WebKit::WebEditCommandProxy> m_command;
WTF:: not needed here.
More information about the webkit-reviews
mailing list