[webkit-reviews] review denied: [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl : [Attachment 97412] Modify PlatformProcessIdentifier.h

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied YoungTaeck Song
<youngtaeck.song at samsung.com>'s request for review:
Bug 62777: [EFL][WK2] Add RunLoopEfl and WorkQueueEfl
https://bugs.webkit.org/show_bug.cgi?id=62777

Attachment 97412: Modify PlatformProcessIdentifier.h
https://bugs.webkit.org/attachment.cgi?id=97412&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97412&action=review

> Source/WebKit2/Platform/WorkQueue.h:222
> +	   public:
> +	       WorkItemEfl(PassOwnPtr<WorkItem> item, WorkQueue* queue) :
m_item(item), m_queue(queue) { }
> +	       ~WorkItemEfl() { }
> +    
> +	       WorkItem* item() const { return m_item.get(); }
> +	       WorkQueue* queue() const { return m_queue; }
> +    
> +	   private:
> +	       OwnPtr<WorkItem> m_item;
> +	       WorkQueue* m_queue;
> +    };
> +    
> +    class FdWorkItem : public WorkItemEfl {
> +	   public:
> +	       FdWorkItem(int fd, PassOwnPtr<WorkItem> item, WorkQueue* queue) 
 
> +		   : WorkItemEfl(item, queue), m_fd(fd) { }
> +	       ~FdWorkItem() { }
> +	       int fd() const { return m_fd; }
> +    
> +	   private:
> +	       int m_fd;
> +    };
> +    
> +    class TermWorkItem : public WorkItemEfl {
> +	   public:
> +	       TermWorkItem(int pid, PassOwnPtr<WorkItem> item, WorkQueue*
queue)
> +		   : WorkItemEfl(item, queue), m_pid(pid) { }
> +	       ~TermWorkItem() { }
> +	       int pid() const { return m_pid; }
> +    
> +	   private:
> +	       int m_pid;
> +    };

The public: and private: should not be indented.  We also traditionally put
each line of the initialization syntax on its own line.