[webkit-reviews] review granted: [Bug 62706] Remove ScriptController::setAllowPopupsFromPlugin : [Attachment 97363] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 62706: Remove ScriptController::setAllowPopupsFromPlugin
https://bugs.webkit.org/show_bug.cgi?id=62706

Attachment 97363: Patch
https://bugs.webkit.org/attachment.cgi?id=97363&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97363&action=review

OK.

> Source/WebKit2/WebProcess/Plugins/PluginView.cpp:786
> +	   UserGestureIndicator gestureIndicator(request->allowPopups() ?
DefinitelyProcessingUserGesture : PossiblyProcessingUserGesture);
> +	   result = frame->script()->executeScript(jsString);

Better to keep passing the bool here for now, and do all of these in a separate
patch.