[webkit-reviews] review denied: [Bug 36793] CSS outline property on a narrow element has rabbit ear artifacts : [Attachment 97392] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jason
<liuyang12341982 at 163.com>'s request for review:
Bug 36793: CSS outline property on a narrow element has rabbit ear artifacts
https://bugs.webkit.org/show_bug.cgi?id=36793

Attachment 97392: Patch
https://bugs.webkit.org/attachment.cgi?id=97392&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97392&action=review

r- for the test

> LayoutTests/ChangeLog:9
> +	   * fonts/outline-expected.txt: Added.
> +	   * fonts/outline.html: Added.

Why is the test in fonts? I'd suggest fast/css

I think the test can also be dumpAsText(true) since you only care about the
pixel result. The test should contain no text, and use large outlines to make
the fix very obvious. You also need to include a pixel result in your patch.