[webkit-reviews] review denied: [Bug 56397] Suppress modal JavaScript/HTML dialogs during unload events : [Attachment 97206] Adds #include for StringBuilder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 14:40:27 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Sreeram Ramachandran
<sreeram at chromium.org>'s request for review:
Bug 56397: Suppress modal JavaScript/HTML dialogs during unload events
https://bugs.webkit.org/show_bug.cgi?id=56397

Attachment 97206: Adds #include for StringBuilder
https://bugs.webkit.org/attachment.cgi?id=97206&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97206&action=review

> LayoutTests/ChangeLog:25
> +	   *
platform/chromium/fast/dom/Geolocation/notimer-after-unload-expected.txt:
Added.
> +	   *
platform/chromium/fast/events/onbeforeunload-focused-iframe-expected.txt:
Added.
> +	   *
platform/chromium/fast/events/onunload-clears-onbeforeunload-expected.txt:
Added.
> +	   * platform/chromium/fast/events/onunload-expected.txt: Added.
> +	   * platform/chromium/fast/events/onunload-not-on-body-expected.txt:
Added.
> +	   *
platform/chromium/fast/events/onunload-window-property-expected.txt: Added.
> +	   *
platform/chromium/fast/events/pageshow-pagehide-on-back-uncached-expected.txt:
Added.
> +	   *
platform/chromium/fast/history/timed-refresh-in-cached-frame-expected.txt:
Added.
> +	   *
platform/chromium/fast/loader/frames-with-unload-handlers-in-page-cache-expecte
d.txt: Added.
> +	   *
platform/chromium/fast/loader/page-dismissal-modal-dialogs-expected.txt: Added.

> +	   *
platform/chromium/fast/loader/recursive-before-unload-crash-expected.txt:
Added.

Please use svn mv first.  It's hard to see what changes you're making to
expected results because you're adding new files.


More information about the webkit-reviews mailing list