[webkit-reviews] review denied: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 97324] 0001 - Add SVGElement::reporteAttributeParsingErrorIfNeeded

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 14:36:33 PDT 2011


Rob Buis <rwlbuis at gmail.com> has denied Tim Horton <timothy_horton at apple.com>'s
request for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 97324: 0001 - Add SVGElement::reporteAttributeParsingErrorIfNeeded
https://bugs.webkit.org/attachment.cgi?id=97324&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97324&action=review

This looks very good! But you need to include the new file in the other build
files as well, like WebCore.gypi, for non OS X builds.

> Source/WebCore/ChangeLog:8
> +	   Add SVGElement::reporteAttributeParsingErrorIfNeeded, which will

Typo in reporteAttributeParsingErrorIfNeeded


More information about the webkit-reviews mailing list