[webkit-reviews] review granted: [Bug 62745] Convert WebNSFileManagerExtras.m to Objective-C++ : [Attachment 97341] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 15 12:27:16 PDT 2011
Joseph Pecoraro <joepeck at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 62745: Convert WebNSFileManagerExtras.m to Objective-C++
https://bugs.webkit.org/show_bug.cgi?id=62745
Attachment 97341: Patch
https://bugs.webkit.org/attachment.cgi?id=97341&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97341&action=review
> Source/WebKit/mac/ChangeLog:14
> + * Misc/WebNSFileManagerExtras.mm: Renamed from
Source/WebKit/mac/Misc/WebNSFileManagerExtras.m.
> + (-[NSFileManager _webkit_carbonPathForPath:]):
> + (setMetaData):
> + (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
> + Added static_cast<MetaDataInfo *>.
> + (-[NSFileManager _webkit_startupVolumeName]):
> + (fileExists):
> + (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]):
In changes like this I normally remove the excess ChangeLog comments.
Only lines 7, 10+11 are needed, the others are all not useful and just
showed up because of the rename.
More information about the webkit-reviews
mailing list