[webkit-reviews] review granted: [Bug 62742] Add ShareableBitmap::createImage and get rid of WebCoreArgumentCodersCG.cpp : [Attachment 97340] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 62742: Add ShareableBitmap::createImage and get rid of
WebCoreArgumentCodersCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=62742

Attachment 97340: Patch
https://bugs.webkit.org/attachment.cgi?id=97340&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97340&action=review

> Source/WebKit2/Shared/ShareableBitmap.h:110
> +    // This create a bitmap image that directly references the shared bitmap
data.

Should be "This creates".

> Source/WebKit2/Shared/ShareableBitmap.h:112
> +    // This is only safe to use when we know that the contents of the
shareable bitmap won't change.
> +    PassRefPtr<WebCore::Image> createImage();

Would be nice if that “this is only safe” information was reflected in the
function name.

> Source/WebKit2/Shared/cg/ShareableBitmapCG.cpp:115
> +    // BitmapImage::create adopts the CGImageRef that's passed in, which is
why we need to leakRef here.

Could that be fixed by changing BitmapImage::create to take a RetainPtr?