[webkit-reviews] review denied: [Bug 62126] [Qt] fast/dom/HTMLDocument/hasFocus.html failed : [Attachment 96090] patch

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied qi
<qi.2.zhang at nokia.com>'s request for review:
Bug 62126: [Qt] fast/dom/HTMLDocument/hasFocus.html failed
https://bugs.webkit.org/show_bug.cgi?id=62126

Attachment 96090: patch
https://bugs.webkit.org/attachment.cgi?id=96090&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96090&action=review

> Source/WebKit/qt/ChangeLog:8
> +	   Clean the FocusController when the windows lose the focus.

Clear is better than clean :D. Typo -> "when the window loses"

>> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:176
>> +	m_webPage->d->page->focusController()->setFocusedFrame(0);    
> 
> Since ChromeClientQt::focus() does not call setFocusedFrame(), it's unlikely
the best place to reset focused frame is in this unfocus() function.
> It seems to me a better place would be QWebPagePrivate::focusOutEvent or
somewhere in QWebFrame. You can try if it works. :)

Yep, the view get the focus cleared therefore the page will receive a
focusOutEvent, sounds like a better place.
focusController->setFocusedFrame(QWebFramePrivate::core(mainFrame)); is done in
the focusInEvent, perhaps we should clear it in the focusOutEvent.