[webkit-reviews] review denied: [Bug 62721] Web Inspector: provide unique identifiers for frames : [Attachment 97287] patch (FrameDestructionObserver -> InspectorInstrumentation)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 07:19:34 PDT 2011


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 62721: Web Inspector: provide unique identifiers for frames
https://bugs.webkit.org/show_bug.cgi?id=62721

Attachment 97287: patch (FrameDestructionObserver -> InspectorInstrumentation)
https://bugs.webkit.org/attachment.cgi?id=97287&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97287&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:594
> +    ASSERT(iterator != m_frameToIdentifier.end());

This assertion will fail due to the lazy identifier assignment.


More information about the webkit-reviews mailing list