[webkit-reviews] review granted: [Bug 61885] [Windows, WinCairo] Add C++ Event Listener Example to WinLauncher : [Attachment 95667] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 14 10:23:36 PDT 2011
Brian Weinstein <bweinstein at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 61885: [Windows, WinCairo] Add C++ Event Listener Example to WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=61885
Attachment 95667: Patch
https://bugs.webkit.org/attachment.cgi?id=95667&action=review
------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95667&action=review
> Tools/ChangeLog:7
> +
A sentence or two about the example you added would be nice here. Talking about
adding an on click event for the WebKit logo, and how someone can test this.
> Tools/WinLauncher/WinLauncher.cpp:177
> + frame->DOMDocument(&doc);
Do you want to check if the frame is the main frame here? Or does it not
matter?
More information about the webkit-reviews
mailing list