[webkit-reviews] review denied: [Bug 62643] Web Inspector: "data" URLs not detected in CSS url(...) values properly : [Attachment 97133] [PATCH] Suggested fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 62643: Web Inspector: "data" URLs not detected in CSS url(...) values
properly
https://bugs.webkit.org/show_bug.cgi?id=62643

Attachment 97133: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=97133&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97133&action=review

> Source/WebCore/inspector/front-end/AuditRules.js:665
> +	       if (!parsedURL || !parsedURL.isDataURL) {

This check seems wrong. Now all parsed non-data urls fall under this branch.

> Source/WebCore/inspector/front-end/CookieItemsView.js:243
> +    if (!url || url.isDataURL ||
!this.cookieDomainMatchesResourceDomain(cookie.domain, url.host))

Will this work as is?

> Source/WebCore/inspector/front-end/inspector.js:1320
> +	   if (parsedHref && (parsedHref.scheme || parsedHref.isDataURL))

No need to change this.