[webkit-reviews] review granted: [Bug 62430] <progress> should support :indeterminate pseudo-class : [Attachment 96951] Patch.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 62430: <progress> should support :indeterminate pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=62430

Attachment 96951: Patch.
https://bugs.webkit.org/attachment.cgi?id=96951&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96951&action=review

> Source/WebCore/html/HTMLProgressElement.cpp:151
> +	   if ((wasIndeterminate && isDeterminate()) || (!wasIndeterminate &&
!isDeterminate()))

We can write this as
  if (wasIndeterminate == isDeterminate())
Also, I think wasIndeterminate should be changed to wasDeterminate.
  bool wasDeterminate = render->isDeterminate();
  render->updateFromEelemnt();
  if (wasDetermiante != isDeterminate)
      setNeedsStyleRecalc();

"if (status is change) setNeedsStyleRecalc()" is a common idiom and easy to
read for us.