[webkit-reviews] review requested: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 97027] Preliminary test (don't cq+), reports SVGLength parse errors on <circle> elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 16:08:32 PDT 2011


Tim Horton <timothy_horton at apple.com> has asked  for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 97027: Preliminary test (don't cq+), reports SVGLength parse errors
on <circle> elements
https://bugs.webkit.org/attachment.cgi?id=97027&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
Is the refactoring of parseMappedAttribute acceptable?

I changed reportMessage() so it passes the documentURI on to the console, so it
shows the document (and, more importantly, the line number). This helps.

One interesting issue: the messages don't appear if you include the SVG in a
HTML document with the <img> tag. I'm not sure why, I'm going to look into this
next.

If this solution works for everyone, I'll forge ahead and apply it to all of
the rest of the usages of SVGLength, and then eventually the other types.


More information about the webkit-reviews mailing list