[webkit-reviews] review granted: [Bug 62385] [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation : [Attachment 96608] Try to fix the cr-linux build

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 62385: [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Attachment 96608: Try to fix the cr-linux build
https://bugs.webkit.org/attachment.cgi?id=96608&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96608&action=review

Great idea!
r=me

> Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:-671
> -	   if (obj->eventLogging)
> -	       pluginLog(instance, "adjustCursorEvent");

This will break plugins/mouse-events.html on chromium-linux.
You can simply remove the chromium-specific expectation for this test.