[webkit-reviews] review granted: [Bug 62213] Create local CG context for Mac UI elements when Skia is renderer : [Attachment 96590] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 9 11:43:42 PDT 2011
Eric Seidel <eric at webkit.org> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 62213: Create local CG context for Mac UI elements when Skia is renderer
https://bugs.webkit.org/show_bug.cgi?id=62213
Attachment 96590: Patch
https://bugs.webkit.org/attachment.cgi?id=96590&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems OK. Adam pointed out we could also call the cgContext method
refreshCGContext() (either on these local classes or on bitlocker). That would
allow us to have a separate cgContext() method which did not refresh but only
returned the last context (or errored if there was none). refreshContext()
could still return the context pointer of course.
Anyway, this looks OK.
More information about the webkit-reviews
mailing list