[webkit-reviews] review denied: [Bug 62279] check for null-shader from gradient factory : [Attachment 96415] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Mike Reed <reed at google.com>'s
request for review:
Bug 62279: check for null-shader from gradient factory
https://bugs.webkit.org/show_bug.cgi?id=62279

Attachment 96415: Patch
https://bugs.webkit.org/attachment.cgi?id=96415&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96415&action=review

We need test coverage for the degenerate case if that's causing the crash.

> Source/WebCore/ChangeLog:8
> +	   No new tests. existing tests exercise the gradient code-path

What existing test covers this codepath?  I would expect one of our current
tests to be crashing without this patch if we had test coverage....

> Source/WebCore/platform/graphics/skia/GradientSkia.cpp:175
> +    // if we got no gradient, the the colors must be degenerate, so

nitpick: Capitalize "if", typo "the the"