[webkit-reviews] review granted: [Bug 61410] Pressing <tab> key should traverse elements in shadow content. : [Attachment 96389] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 61410: Pressing <tab> key should traverse elements in shadow content.
https://bugs.webkit.org/show_bug.cgi?id=61410

Attachment 96389: Patch
https://bugs.webkit.org/attachment.cgi?id=96389&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96389&action=review

> Source/WebCore/page/FocusController.cpp:174
> +	       // FIXME: Some elements (e.g. HTMLInputElement and
HTMLTextAreaElement) do extra work in their focus() methods.

File a bug and mention here so that we know when it's safe to remove this
comment.

> Source/WebCore/page/FocusController.cpp:176
> +	       if (node->nodeName() == "INPUT" || node->nodeName() ==
"TEXTAREA")

Please	use hasTagName here.