[webkit-reviews] review denied: [Bug 53894] [Qt] Very jerky scrolling because of blocking in tiled backing store. : [Attachment 96338] Patch 6: Do some tiles updates directly from paint to reduce flicker.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Viatcheslav
Ostapenko <ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 53894: [Qt] Very jerky scrolling because of blocking in tiled backing
store.
https://bugs.webkit.org/show_bug.cgi?id=53894

Attachment 96338: Patch 6: Do some tiles updates directly from paint to reduce
flicker.
https://bugs.webkit.org/attachment.cgi?id=96338&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96338&action=review

> Source/WebCore/ChangeLog:9
> +	   Do some tiles updates directly from paint to reduce flicker.

Why does that help... needs better change log.

> Source/WebCore/page/Frame.cpp:966
> -void Frame::tiledBackingStorePaintBegin()
> +bool Frame::tiledBackingStorePaintBegin()

Very bad api, I have no clue what the returned bool could mean

> Source/WebCore/page/Frame.cpp:971
> +    if(m_view->isInLayout())
> +	   return false;

yes again you submit a patch with wrong coding style...

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:45
> +    , m_inUpdate(false)

Could be more descriptive