[webkit-reviews] review denied: [Bug 53894] [Qt] Very jerky scrolling because of blocking in tiled backing store. : [Attachment 96336] Patch 4: Prioritize tile paiting. Viewport area is updated 1st and missing tiles are updated before dirty.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 02:20:03 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Viatcheslav
Ostapenko <ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 53894: [Qt] Very jerky scrolling because of blocking in tiled backing
store.
https://bugs.webkit.org/show_bug.cgi?id=53894

Attachment 96336: Patch 4: Prioritize tile paiting. Viewport area is updated
1st and missing tiles are updated before dirty.
https://bugs.webkit.org/attachment.cgi?id=96336&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96336&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:430
> +	       if (tile) {
> +		   if(tile->isDirty()) {
> +		      
dirtyTiles.append(CoordinateDistancePair(currentCoordinate,
currentTileDistance));
> +		   }
> +	       } else {
> +		  
missingTiles.append(CoordinateDistancePair(currentCoordinate,
currentTileDistance));
> +	       }

You are wasting reviewers time, why didnt you even run the check-webkit-style
script?


More information about the webkit-reviews mailing list