[webkit-reviews] review granted: [Bug 62177] Switch paint to use IntPoint : [Attachment 96269] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 7 11:47:10 PDT 2011
Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 62177: Switch paint to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62177
Attachment 96269: Patch
https://bugs.webkit.org/attachment.cgi?id=96269&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96269&action=review
LGTM.
> Source/WebCore/rendering/RenderBoxModelObject.cpp:699
> + IntSize localOffset = isBox() ?
toRenderBox(this)->locationOffset() : IntSize();
I could have sworn there is a renderBoxRect() method somewhere which does
something like this. This is fine, just there may already be a helper for
this.
> Source/WebCore/rendering/RenderObject.cpp:1148
> +void RenderObject::paint(PaintInfo& /*paintInfo*/, const IntPoint&
/*paintOffset*/)
I don't think these comments add much of anything.
> Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:102
> + info.context->drawLine(IntPoint(adjustedPaintOffset.x(),
adjustedPaintOffset.y() + topStart), IntPoint(adjustedPaintOffset.x() +
offsetWidth(), adjustedPaintOffset.y() + topStart));
Locals or IntSize additions might make this cleaner. Can be done in later
passes.
> Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:135
> + RenderSVGContainer::paint(info, IntPoint());
I wonder if paint() should take a default argument for this point now. :)
More information about the webkit-reviews
mailing list