[webkit-reviews] review granted: [Bug 62222] JSStaticFunction and JSStaticValue are overly "const" : [Attachment 96270] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 11:42:32 PDT 2011


Darin Adler <darin at apple.com> has granted Juan C. Montemayor <j.mont at me.com>'s
request for review:
Bug 62222: JSStaticFunction and JSStaticValue are overly "const"
https://bugs.webkit.org/show_bug.cgi?id=62222

Attachment 96270: proposed patch
https://bugs.webkit.org/attachment.cgi?id=96270&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=96270&action=review

Seems OK to change this. The other data members aren’t const, and there’s no
strong argument for making these const.

>> Source/JavaScriptCore/ChangeLog:5
>> +	    Make JSStaticFunction and JSStaticValue less "const"
> 
> Why?

I think I see why now.


More information about the webkit-reviews mailing list