[webkit-reviews] review requested: [Bug 62149] Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on. : [Attachment 96124] Patch

[bugzilla-daemon at webkit.org]

Vangelis Kokkevis <vangelis at chromium.org> has asked  for review:
Bug 62149: Web Inspector: [Chromium] DevTools does not highlight elements when
accelerated compositing is on.
https://bugs.webkit.org/show_bug.cgi?id=62149

Attachment 96124: Patch
https://bugs.webkit.org/attachment.cgi?id=96124&action=review

------- Additional Comments from Vangelis Kokkevis <vangelis at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96124&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:90
> +	   hudSize.setWidth(m_layerRenderer->viewportSize().width());

still need to clamp to the max texture size .  An example can be found in
DrawingBuffer::reset() (DrawingBuffer.cpp)

> Source/WebKit/chromium/src/PageOverlay.cpp:84
> +    if (!m_viewImpl->isAcceleratedCompositingActive()) {

isAcceleratedCompositingActive() needs to be protected by
USE(ACCELERATED_COMPOSITING) guards.

> Source/WebKit/chromium/src/PageOverlay.cpp:105
> +void PageOverlay::webFramePainted(GraphicsContext& gc)

The method should probably be named using an active verb.  paintWebFrame ?