[webkit-reviews] review granted: [Bug 62130] Convert RenderBox::absoluteRects to IntPoint : [Attachment 96129] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 62130: Convert RenderBox::absoluteRects to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62130

Attachment 96129: Patch
https://bugs.webkit.org/attachment.cgi?id=96129&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96129&action=review

> Source/WebCore/rendering/RenderInline.cpp:474
> +	       rects.append(enclosingIntRect(FloatRect(accumulatedOffset +
curr->topLeft(), IntSize(curr->width(), curr->height()))));

It might be worth adding a InlineBox::size(), even just for thsi one caller.

> Source/WebCore/rendering/RenderText.cpp:275
> +	   rects.append(enclosingIntRect(FloatRect(accumulatedOffset +
box->topLeft(), IntSize(box->width(), box->height()))));

two callers. :)