[webkit-reviews] review granted: [Bug 62089] [Qt] Fix and unskip acid2 : [Attachment 96019] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 62089: [Qt] Fix and unskip acid2
https://bugs.webkit.org/show_bug.cgi?id=62089

Attachment 96019: Patch
https://bugs.webkit.org/attachment.cgi?id=96019&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96019&action=review

Looks good, r=me.

> Source/WebKit/qt/ChangeLog:18
> +	   Some ports also check when WebKitErrorPluginWillHandleLoad deciding
> +	   what to return. This error isn't currently set by Qt so we don't
check

This looks a bit jumbled.
Some ports also check WebKitErrorPluginWillHandleLoad when deciding what to
return?

> Source/WebKit/qt/ChangeLog:20
> +	   it. (Other ports set it when the erring document is a MediaDocument,
maybe
> +	   we should do that too at some point).

Sounds like you should file a bug about that. :)