[webkit-reviews] review granted: [Bug 61076] Teach platform/win about window.internals : [Attachment 96018] Fixes tabs in WebKit2.def.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dominic Cooney
<dominicc at chromium.org>'s request for review:
Bug 61076: Teach platform/win about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61076

Attachment 96018: Fixes tabs in WebKit2.def.
https://bugs.webkit.org/attachment.cgi?id=96018&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96018&action=review

Yay Dominic!!

Adam, Jeff, Jer -- does this look sane to you?

> Source/WebKit2/win/WebKit2.def:140
> +	   ; Re-exports from WebCore for WebCoreTestSupport
> +	  
?getCachedDOMStructure at WebCore@@YAPAVStructure at JSC@@PAVJSDOMGlobalObject at 1@PBUC
lassInfo at 3@@Z
> +	  
?cacheDOMStructure at WebCore@@YAPAVStructure at JSC@@PAVJSDOMGlobalObject at 1@PAV23 at PB
UClassInfo at 3@@Z
> +	   ?virtualFunctionToPreventWeakVtable at JSDOMWrapper@WebCore@@MAEXXZ

This seems troubling. I didn't realize we'd have to do this for Windows too :(

I wonder if a "safely-export-symbol-across-platform" tool is in the cards for
us.