[webkit-reviews] review granted: [Bug 62032] Convert RenderBox::overflowClipRect to IntPoint : [Attachment 95970] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 15:39:25 PDT 2011


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 62032: Convert RenderBox::overflowClipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62032

Attachment 95970: Patch
https://bugs.webkit.org/attachment.cgi?id=95970&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95970&action=review

LGTM.

> Source/WebCore/rendering/RenderBox.cpp:1148
> +	   clipRect.contract(layer()->verticalScrollbarWidth(relevancy),
> +	       layer()->horizontalScrollbarHeight(relevancy));

I wouldn't have bothered wrapping. 1. cause we have no column limit in webkit. 
and 2. because as soon as you make it 2 lines, we technically would require { }
around the if block (even though the executed code is one line).


More information about the webkit-reviews mailing list