[webkit-reviews] review granted: [Bug 61888] nrwt: should skip chromium test expectation overrides on upstream bots : [Attachment 95680] chromium-specific version

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 61888: nrwt: should skip chromium test expectation overrides on upstream
bots
https://bugs.webkit.org/show_bug.cgi?id=61888

Attachment 95680: chromium-specific version
https://bugs.webkit.org/attachment.cgi?id=95680&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95680&action=review

I think we should move forward with this approach.  Introducing a yet another
test_expectations file is too much complexity.	We'll find a way to do Skia
rolls without this functionality.

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:265
> +	   # See http://bugs.webkit.org/show_bug.cgi?id=61888 for the rationale
for this.

I'd remove this comment.  Folks can use svn blame to find the bug number.