[webkit-reviews] review denied: [Bug 62032] Convert RenderBox::overflowClipRect to IntPoint : [Attachment 95954] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 62032: Convert RenderBox::overflowClipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62032

Attachment 95954: Patch
https://bugs.webkit.org/attachment.cgi?id=95954&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95954&action=review

> Source/WebCore/rendering/RenderBox.cpp:1145
> +    IntRect clipRect(location + borderTopLeft(), size() - borderSize());

borderSize() = IntSize(borderRight(), borderBottom)?

> Source/WebCore/rendering/RenderBoxModelObject.h:95
> +    virtual IntSize borderSize() const { return IntSize(borderLeft() +
borderRight(), borderTop() + borderBottom()); }

Hmmm... Seems we should get this from the borderRect(), I'm not sure borderSize
is meaningful.

> Source/WebCore/rendering/RenderLayer.h:258
> +    IntSize scrollbarSize(OverlayScrollbarSizeRelevancy =
IgnoreOverlayScrollbarSize) const;

This doesn't make any sense.  The vertical and horizontal scrollbars are
indepenent.  How can we put them both into a single size?