[webkit-reviews] review denied: [Bug 61662] [Chromium] putImageData and drawImage fail with accelerated 2d canvas : [Attachment 95920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 3 11:51:45 PDT 2011


James Robinson <jamesr at chromium.org> has denied Justin Novosad
<junov at chromium.org>'s request for review:
Bug 61662: [Chromium] putImageData and drawImage fail with accelerated 2d
canvas
https://bugs.webkit.org/show_bug.cgi?id=61662

Attachment 95920: Patch
https://bugs.webkit.org/attachment.cgi?id=95920&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Sorry, this doesn't compile on ToT and it doesn't really make sense.  The
canvas context should be fairly independent of the compositor context, so
flushing the compositor's context should have no effect.

I wonder if this is exposing some timing issue in the command buffer or in
ganesh internals.  As frustrating as I know this is for you, we really need to
have a full understanding of this issue to make sure that we are fixing the
real root cause bug here and not just patching up one manifestation.


More information about the webkit-reviews mailing list