[webkit-reviews] review granted: [Bug 61734] [GTK] Support smart replace for the pasteboard : [Attachment 95923] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 61734: [GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Attachment 95923: Patch
https://bugs.webkit.org/attachment.cgi?id=95923&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95923&action=review

> Source/WebCore/platform/gtk/PasteboardGtk.cpp:65
> +								       
PasteboardHelper::DoNotIncludeSmartPaste);

I don't think we indent deep like this.  We normally do:
helper->writeClipboardContents(clipboard, canSmartCopyOrDelete ?
PasteboardHelper::IncludeSmartPaste :
    PasteboardHelper::DoNotIncludeSmartPaste);

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:616
> +    WebKit::EditorClient* client =
static_cast<WebKit::EditorClient*>(core(webView)->editorClient());
> +    client->setSmartInsertDeleteEnabled(enabled);

Can webView or client ever be null?