[webkit-reviews] review denied: [Bug 60059] AssociatedURLLoader reports some errors synchronously : [Attachment 95791] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 60059: AssociatedURLLoader reports some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=60059

Attachment 95791: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=95791&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95791&action=review

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:89
> +    OwnPtr<Timer<ClientAdapter> > m_errorTimer;

This should just be a regular member, not an OwnPtr.

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:190
> +void AssociatedURLLoader::ClientAdapter::notifyError(Timer<ClientAdapter>*
timer)

You should assert that |timer| has the value you expect.