[webkit-reviews] review denied: [Bug 54929] REGRESSION: Text selection broken for text with line-height applied : [Attachment 94178] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 1 20:29:48 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 54929: REGRESSION: Text selection broken for text with line-height applied
https://bugs.webkit.org/show_bug.cgi?id=54929

Attachment 94178: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=94178&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94178&action=review

> LayoutTests/editing/selection/hit-test-on-text-with-line-height.html:38
> +	   document.writeln('FAIL - selection was not collapsed');
> +    else if (selection.baseNode != textNode)
> +	   document.writeln('FAIL - baseNode was not "' + textNode.textContent
+ '"');
> +    else if (selection.baseOffset != expectedOffset)
> +	   document.writeln('FAIL - caret was at ' + selection.baseOffset + '
but expected to be at ' + expectedOffset);
> +    else
> +	   document.writeln('PASS');

Please don't use document.writeln(). Append to innerText or innerHTML instead.

This whole test could probably be a script test.


More information about the webkit-reviews mailing list