[webkit-reviews] review denied: [Bug 55481] Consider padding and border when looking for the next/previous line position : [Attachment 95435] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 55481: Consider padding and border when looking for the next/previous line
position
https://bugs.webkit.org/show_bug.cgi?id=55481

Attachment 95435: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=95435&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95435&action=review

>
LayoutTests/editing/selection/caret-mode-vertical-navigation-with-links.html:37

> +  shouldBe("getSelection().baseOffset", "10");
> +  shouldBe("getSelection().anchorNode.nodeValue", "'A long paragraph with
some '");
> +  eventSender.keyDown("downArrow");
> +  shouldBe("getSelection().baseOffset", "3");
> +  shouldBe("getSelection().anchorNode.nodeValue", "'them'");

This test doesn't work because depending on font metrics of a port/platform,
the text is wrapped differently.