[webkit-reviews] review granted: [Bug 65331] Web Inspector: [protocol] methods where all parameters are optional should not require empty params object. : [Attachment 102277] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65331: Web Inspector: [protocol] methods where all parameters are optional
should not require empty params object.
https://bugs.webkit.org/show_bug.cgi?id=65331

Attachment 102277: Patch
https://bugs.webkit.org/attachment.cgi?id=102277&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102277&action=review


> Source/WebCore/inspector/CodeGeneratorInspector.pm:599
> +	       protocolErrors->pushString(String::format("'params' object
should contain required parameter '\%s' with type '$json'.",
name.utf8().data()));

should -> must?