[webkit-reviews] review granted: [Bug 65321] Web Inspector: group scripts by folder in the scripts selector. : [Attachment 102264] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 31 23:16:44 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 65321: Web Inspector: group scripts by folder in the scripts selector.
https://bugs.webkit.org/show_bug.cgi?id=65321
Attachment 102264: Patch
https://bugs.webkit.org/attachment.cgi?id=102264&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102264&action=review
Before landing the change please make sure the test passes on Chromium.
> Source/WebCore/inspector/front-end/ScriptsPanel.js:268
> + option.nameForSorting = folderNameForSorting + "\t/\t" +
names.displayName; // User Tab to make files stick to their folder.
Please fix the misleading comment.
More information about the webkit-reviews
mailing list