[webkit-reviews] review granted: [Bug 65374] WebSocket: Rename SocketStreamHandleClient methods : [Attachment 102357] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 65374: WebSocket: Rename SocketStreamHandleClient methods
https://bugs.webkit.org/show_bug.cgi?id=65374

Attachment 102357: Patch
https://bugs.webkit.org/attachment.cgi?id=102357&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102357&action=review


> Source/WebCore/ChangeLog:3
> +	   WebSocket: Rename SocketStreamHandleClient methods

nit: In C++, they are called "member function", not "method".

> Source/WebCore/ChangeLog:8
> +	   Rename SocketStreamHandleClient methods to avoid conflict of the
names of FileReaderLoaderClient methods.

ditto.

> Source/WebCore/websockets/WebSocketChannel.h:68
> +	   // SocketStreamHandleClient methods.

ditto.

> Source/WebKit/chromium/ChangeLog:3
> +	   WebSocket: Rename SocketStreamHandleClient methods

ditto.