[webkit-reviews] review denied: [Bug 58013] [Chromium] Needs eventSender.scalePageBy() : [Attachment 102370] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 58013: [Chromium] Needs eventSender.scalePageBy()
https://bugs.webkit.org/show_bug.cgi?id=58013

Attachment 102370: Patch
https://bugs.webkit.org/attachment.cgi?id=102370&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102370&action=review


> LayoutTests/ChangeLog:21
> +	   *
platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
Added.
> +	   *
platform/chromium-linux/fast/repaint/scale-page-shrink-expected.png: Added.
> +	   *
platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Added.
> +	   *
platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected
.txt: Removed.
> +	   *
platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.t
xt: Removed.
> +	   *
platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected
.txt: Removed.
> +	   *
platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt:
Removed.
> +	   *
platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.t
xt: Removed.
> +	   *
platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt:
Removed.
> +	   * platform/chromium/test_expectations.txt: Enabled three tests.

It seems we need new expectation files for the followings on chromium-mac and
chromium-win.

compositing/scaling/tiled-layer-recursion.txt
repaint/scale-page-shrink.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/dom/Range/scale-page-client-rect.html

Removing wrong expectations is ok, but removing entries in
test_expectations.txt wil break the tests because of lack of correct
expectations.

> Source/WebKit/chromium/public/WebView.h:209
> +    // Page scaling --------------------------------------------------------

> +
> +    // Scales a page by a factor of scaleFactor and then sets a scroll
position to (x, y).
> +    virtual void scalePageBy(float scaleFactor, float x, float y) = 0;

Changing public interface only for DumpRenderTree should be avoided.
Can you move EventSender.scalePageBy() to window.internals.scalePageBy() ?