[webkit-reviews] review canceled: [Bug 58043] Unify the way we generate HTML for an image in the Clipboard : [Attachment 102352] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 29 11:44:04 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has canceled Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 58043: Unify the way we generate HTML for an image in the Clipboard
https://bugs.webkit.org/show_bug.cgi?id=58043

Attachment 102352: Patch
https://bugs.webkit.org/attachment.cgi?id=102352&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
(In reply to comment #12)
> Switching from imageToMarkup to createMarkup sounds good to me.
> 
> It's not clear to me how/why the new tests fail on chromium, but maybe if you
combined the tests and code change into a single patch, the cr-linux ews bot
would pass?

The problem on chromium is that you need a src attribute and everything is
converted to <img>.

I will make an update with a speculative patch :)


More information about the webkit-reviews mailing list